add Modbus Sunspec compatibility to opendtu-onbattery #1150

AloisKlingler · 2024-08-03T08:15:37Z

this implementation is (maybe only partially) modbus-sunspec compatibility to simulate a sunspec energy-meter.

to have calculation (especially self-consumption) correct for e.g. fronius solar web you need to either place a 300€ fronius smart meter before each "foreign" inverter.

With this PR it is possible to configure OpenDTU with it's IP-address as a "Smartmeter" on Fronius Gen24 or Fronius Symo inverter. so the Fronius Inverter is able to poll current production and overall production continuously like a from a real fronius-smartmeter.

necessary configuration on OpenDTU:

configuration on an Gen24 Inverter:

visualisation on an Gen24 inverter:

visualisation of the additional "Smartmeter" in Fronius Solarweb as "Additional AC Source":

visualisation of the "Smartmeter" data in Solarweb is available as common curve like other inverters are:

for my OpenDTU (and also some other users of photovoltaikforum.com) this implementation is running now over a year (more or less) flawless.

to the PR: the tree conflicting files webapp_dist/* need to be resolved on merge. other conflicts I could solve.

This reverts commit 5617240ce1fb15a3796d1ed558cc89f9ba72d8d5.

… "Total Power" and "Total Yield" into registers.

merge 23.6.26

prevent sending 0 as "e_energy_exported" to avoid peaks and gaps in solarweb statistic

…niusSM-MB

merge v23.6.28

merge v23.8.3

spcqike · 2024-08-05T06:05:50Z

thanks for your effort.

another thing, it would be good, if your changes would be based on helgeerbe:development or :master, too.

right now, your changes are based on a fork of the upstream project, which makes it difficult to compare or include as there may be many more changes than you actually want to add.

On the other hand, it is now only "+278/-3", which is much less than the previous "+3,652/-2,191". So I think the developer can work with that.

…spec vendor data

merge v24.8.5

AloisKlingler · 2024-08-06T06:20:14Z

thanks for your effort.

another thing, it would be good, if your changes would be based on helgeerbe:development or :master, too.

right now, your changes are based on a fork of the upstream project, which makes it difficult to compare or include as there may be many more changes than you actually want to add.

On the other hand, it is now only "+278/-3", which is much less than the previous "+3,652/-2,191". So I think the developer can work with that.

I am sorry for the confusion
I recognized yesterday that the implementation is already a at least SunSpec meter compatible implementation.
It looks like (at least) fronius inverters then only have additional checks for e.g. vendor to allow them beeing configured.

In a yet (in my repository) not commited change I created configuration for the necessary sunspec fields so it may be compatible with other inverters which do the same.

I will update this PR as soon as I have tested all the changes well enough.

add configuration for elements to equip with custom vendor strings.

AndreasBoehm · 2024-08-21T05:42:04Z

There are still a lot of unrelated changes, please make sure that you base your branch off of the OpenDTU-OnBattery development branch.

to the PR: the tree conflicting files webapp_dist/* need to be resolved on merge. other conflicts I could solve.

Please do not commit any file within webapp_dist/. This is done by the upstream project OpenDTU but within the OnBattery repo we don't do that, not sure why but i can imagine that its because of the conflicts that would arise constantly.

AndreasBoehm · 2024-08-21T05:45:02Z

include/Configuration.h

@@ -76,6 +76,16 @@ struct CONFIG_T {
        bool Enabled;
    } Mdns;

+    struct {


Please also add bool verboseLogging to your struct and use that to enable/disable logging within your Modbus module instead of commenting the logging lines.

AndreasBoehm · 2024-08-21T05:46:12Z

platformio.ini

@@ -45,6 +45,7 @@ lib_deps =
    nrf24/RF24 @ 1.4.9
    olikraus/U8g2 @ 2.35.19
    buelowp/sunset @ 1.1.7
+    https://github.com/emelianov/modbus-esp8266#master


Can we point to a specific commit or release-tag instead of a branch?
This might break builds at any point in the future without us knowing whats going on.

currently not, as there is a change which is most probably needed in master only:
emelianov/modbus-esp8266#292

as soon as there is a 4.1.2 (or whatever) released I think this one could be used.

If you specific the commit hash with #a5872af7250e03e9a5cd578366b0c2cdc097fcc9 instead of #master you can make sure that the dependency won't get updated randomly with the next push to master

AndreasBoehm · 2024-08-21T05:47:22Z

src/ModbusDtu.cpp

+                        // mb.Hreg(0x9cbb, 0);
+                        // mb.Hreg(0x9cbc, 0);
+                        // mb.Hreg(0x9cbd, 0);
+                        // mb.Hreg(0x9cbe, 0);
+                        // mb.Hreg(0x9cbf, 0);
+                        // mb.Hreg(0x9cc0, 0);
+                        // value = (inv->Statistics()->getChannelFieldValue(TYPE_AC, CH0, FLD_YT)*1000); //done above already!
+                        // if (value > _lasttotal) {
+                            // _lasttotal = value;
+                            // mb.Hreg(0x9cc1, hexbytes[1]); //done above already!
+                            // mb.Hreg(0x9cc2, hexbytes[0]); //done above already!
+                        // }


Please remove commented lines if they are not needed

AndreasBoehm · 2024-08-21T05:48:45Z

src/ModbusDtu.cpp

+
+ModbusDtuClass ModbusDtu;
+
+ModbusDtuClass::ModbusDtuClass()


Wouldn't it make more sense if we call it ModbusSunspec or SunspecModbus to explain what this is actually doing?

Do you have any documentation about the protocol that youa re implementing here?

this implementation is (maybe only partially) modbus-sunspec compatibility to simulate a sunspec energy-meter.

as far as I could google, this should match to "sunspec meter" registers in float mode.
I could not check if it is the complete protocol or only partial.
at least, if I check against fronius documentation, it is complete.

github-actions · 2025-02-01T04:11:31Z

This pull-request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

AloisKlingler · 2025-02-04T07:53:03Z

@AndreasBoehm @schlimmchen @stefan123t
if I would change the above things, will the PR be merged?
what I can tell, the last released version from https://github.com/AloisKlingler/OpenDTU-FroniusSM-MB/releases/tag/v24.8.5-0.3.1 (the one with this PR) is running absolutely stable for me with one inverter. also about 10-20 users from photovoltaikforum.com use it and do not report issues.

I am not sure when I find time to do the changes requested above. my issue is, that adapting / merging to current OpenDTU versions (or also OpenDTU-OnBattery) is very time consuming caused by my knowledge.

it looks like there are some enhancement requests regarding ModbusTCP, I am happy if I can help, but I maybe need your help too if it is really wanted to be merged.

Thanks.

Best regards
Alois

AndreasBoehm · 2025-02-04T10:30:30Z

src/ModbusDtu.cpp

+            mb.Hreg(0x9cc2, hexbytes[0]);
+        }
+
+        if (Hoymiles.getNumInverters() == 1) {


what if a user has configured multiple inverters?
Now that the DPL supports multiple inverters we shall not limit this feature a single inverter only.

with multiple inverters the modbus data for total power (40097 and 40098) and yieldtotal (40129 and 40130) is filled.
those two values are the important one which are accumulateable easily (like already done in the "Total Yield Total" and "Total Power" in webgui)

other data (like frequency, voltage, etc.) is not filled, as we do not know from which source to take, and accumulating / calculating averages makes no sense at all.
this data is not mandatory (at least not for fronius inverters) to accept the ModbusTCP as smartmeter.

AndreasBoehm · 2025-02-04T10:33:13Z

Let's talk about more about what this PR or your feature actually does, at least how i understood it. Please correct me if any of my assumptions are wrong.

Its a ModbusTCP server that will be polled by other hardware to get data
For this ModbusTCP server you implemented registers according to the 'SunSpec'-protocol

Changes that i would suggest

it should have its own settings page as i don't see that its related to 'Network'
classes, structs, fields need clear names, keeping ModbusTCPServer in mind
cleanup the code, add more comments to make it easier to read and undrstand
link a sunspec protocol documentation

I am wondering if this would be something that should be in the upstream project as its not related to having a battery at all?
https://github.com/tbnobody/OpenDTU

AloisKlingler · 2025-02-04T12:09:07Z

Let's talk about more about what this PR or your feature actually does, at least how i understood it. Please correct me if any of my assumptions are wrong.

Its a ModbusTCP server that will be polled by other hardware to get data

For this ModbusTCP server you implemented registers according to the 'SunSpec'-protocol

exactly.

Changes that i would suggest

it should have its own settings page as i don't see that its related to 'Network'

classes, structs, fields need clear names, keeping ModbusTCPServer in mind

cleanup the code, add more comments to make it easier to read and undrstand

link a sunspec protocol documentation

I copied existing elements with great difficulty to have the here available settings. I am sure I cannot manage to create its own page

renaming I can do, only the here mentioned? #1150 (comment)

code cleanup I think I can not do satisfying enough. I tried to make the code already best readable as possible for me.

the sunspec protocol documentation looks to be liable to pay costs: https://sunspec.org/sunspec-modbus-specifications/
I had as reference fronius registers (https://www.fronius.com/de/solarenergie/installateure-partner/technische-daten/alle-produkte/anlagen-monitoring/offene-schnittstellen/modbus-tcp) and also kostal registers (https://optosolar.se/produktfiler/modbusprotkollengelskakostalplenticoreplus.pdf)

I am wondering if this would be something that should be in the upstream project as its not related to having a battery at all? https://github.com/tbnobody/OpenDTU

there a previous modbus implementation was asked to offer a PR here.

stefan123t · 2025-02-04T14:25:32Z

@AloisKlingler there are three compatibel standards mentioned on the sunspec page you referred to:

IEEE 1547-2018 - IEEE Standard for Interconnection and Interoperability of Distributed Energy Resources with Associated Electric Power Systems Interfaces (aka SunSpec)
IEEE 2030.5-2018 - IEEE Standard for Smart Energy Profile Application Protocol
IEEE 1815-2012 - IEEE Standard for Electric Power Systems Communications-Distributed Network Protocol (DNP3)

I have been able to download the IEEE_1547-2018_SunSpec.pdf PDF specifications for Distributed Energy Resource (DER) interoperability using the protocols defined in IEEE 2030.5-2018, IEEE 1815-2012 and SunSpec ModBus over TCP/IP transport via Ethernet / RS-485 (only the latter) from the above site. The other two are behind a paywall, access to which might be available to scientific researchers.

I agree with you all that it would be worthwhile to include this in the upstream project as it enables a standard ModBus interface besides MQTT and Web API to share data from the Hoymiles DTUs in the OpenDTU project.
Unfortunately @tbnobody and @schlimmchen have shown no need to include this functionality neither here tbnobody#582 nor there tbnobody#1893 so it was tried to add it to OpenDTU-OnBattery as it may be more applicable to integration with other Distribute Energy Resources.

I hope this may be (re-)considered at a later stage, once the PR has been more refined to both projects coding standards.

ArekKubacki and others added 30 commits February 13, 2023 10:42

Add Modbus

4084b4d

Added Modbus

cc98831

Merge remote-tracking branch 'origin/master'

ddb0325

Checking that the measurement does not exceed the max Power

802601a

Modbus BugFix

0777a9c

Modbus BugFix

53b9690

Added WatchDog to Modbus

e13348c

Update from master

32b9750

Merge branch 'master' into master

3277e71

Revert "Merge branch 'master' into v1"

1b8b56f

This reverts commit 5617240ce1fb15a3796d1ed558cc89f9ba72d8d5.

Merge branch 'tbnobody-master'

314b285

Edit platformio.ini

6ec026b

Fixed Temperature, Frequency etc.

5077d03

Merge remote-tracking branch 'origin/master'

8d52334

Modbus fixed

a3b2457

Fixed Temp, Freq, AC

54e1641

Merge remote-tracking branch 'origin/master'

2d9c942

Merge

45c9984

Merge

adeed86

Modbus Added

0fb144f

ModbusDtu h file fixed

6765ab6

Fixed Modbus Library

f7678a0

simulating a Fronius Smart Meter with openDTU. currently only feeding…

acdd4ed

… "Total Power" and "Total Yield" into registers.

if only one inverter is connected, use its measurement data.

5684efa

Merge pull request #1 from tbnobody/master

909e53b

merge 23.6.26

adding totals as webapi live

634f962

prevent sending 0 as "e_energy_exported" to avoid peaks and gaps in solarweb statistic

Merge branch 'master' of https://github.com/AloisKlingler/OpenDTU-Fro…

e551d8d

…niusSM-MB

Merge pull request #2 from tbnobody/master

7a09c3d

merge v23.6.28

disable wifi powersave mode

e6ec4e4

Merge pull request #3 from tbnobody/master

a4e8644

merge v23.8.3

Alois Klingler and others added 2 commits August 4, 2024 10:03

rectify settings.json

7a4cf2f

Update main.cpp

93ab87c

AloisKlingler marked this pull request as ready for review August 4, 2024 08:12

Alois Klingler and others added 2 commits August 5, 2024 13:01

extract strings to have a better possibility to configure dynamic sun…

61b2d98

…spec vendor data

Merge pull request #15 from tbnobody/master

389f982

merge v24.8.5

AloisKlingler marked this pull request as draft August 6, 2024 06:20

Alois Klingler added 2 commits August 6, 2024 15:18

from Fronius-Simulation to SunSpec-OpenDTU compatibility.

ad04999

add configuration for elements to equip with custom vendor strings.

fix delayed starting of modbus server

7a2ae06

AloisKlingler changed the title ~~add fronius smartmeter simulation to opendtu-onbattery~~ add Modbus Sunspec compatibility to opendtu-onbattery Aug 7, 2024

AloisKlingler marked this pull request as ready for review August 7, 2024 08:45

AndreasBoehm reviewed Aug 21, 2024

View reviewed changes

schlimmchen force-pushed the development branch 2 times, most recently from 91cc2fc to 8ff94e7 Compare September 16, 2024 14:10

stefan123t mentioned this pull request Oct 27, 2024

Feature Request: Einspeise-Steuerung via ModBus RS485 lumapu/ahoy#431

Open

21 tasks

stefan123t mentioned this pull request Nov 22, 2024

[Request] Support for Modbus TCP energy meters. #1410

Open

AndreasBoehm added the changes requested label Jan 16, 2025

github-actions bot added the stale label Feb 1, 2025

AndreasBoehm reviewed Feb 4, 2025

View reviewed changes

github-actions bot removed the stale label Feb 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Modbus Sunspec compatibility to opendtu-onbattery #1150

add Modbus Sunspec compatibility to opendtu-onbattery #1150

AloisKlingler commented Aug 3, 2024 •

edited

Loading

spcqike commented Aug 5, 2024

AloisKlingler commented Aug 6, 2024

AndreasBoehm commented Aug 21, 2024 •

edited

Loading

AndreasBoehm Aug 21, 2024

AndreasBoehm Aug 21, 2024

AloisKlingler Aug 21, 2024

AndreasBoehm Aug 21, 2024

AndreasBoehm Aug 21, 2024

AndreasBoehm Aug 21, 2024

AloisKlingler Aug 21, 2024

github-actions bot commented Feb 1, 2025

AloisKlingler commented Feb 4, 2025

AndreasBoehm Feb 4, 2025

AloisKlingler Feb 4, 2025

AndreasBoehm commented Feb 4, 2025

AloisKlingler commented Feb 4, 2025

stefan123t commented Feb 4, 2025


		ModbusDtuClass ModbusDtu;

		ModbusDtuClass::ModbusDtuClass()

add Modbus Sunspec compatibility to opendtu-onbattery #1150

Are you sure you want to change the base?

add Modbus Sunspec compatibility to opendtu-onbattery #1150

Conversation

AloisKlingler commented Aug 3, 2024 • edited Loading

spcqike commented Aug 5, 2024

AloisKlingler commented Aug 6, 2024

AndreasBoehm commented Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 1, 2025

AloisKlingler commented Feb 4, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndreasBoehm commented Feb 4, 2025

AloisKlingler commented Feb 4, 2025

stefan123t commented Feb 4, 2025

AloisKlingler commented Aug 3, 2024 •

edited

Loading

AndreasBoehm commented Aug 21, 2024 •

edited

Loading